fix(render): edge environment errors with MessageChannel #2225
+270
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8549fa1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
gabrielmfern
force-pushed
the
canary
branch
6 times, most recently
from
2eba90b to
98c3d9b
Compare
gabrielmfern
force-pushed
the
canary
branch
3 times, most recently
from
0074ddf to
f7e553f
Compare
gabrielmfern
force-pushed
the
feat/use-react-dom-edge-export
branch
from
201fd73 to
b5b9089
Compare
|
Does this address also this issue? #1630 |
|
@adrai yes, but introduces another error for Next.js running on the edge |
gabrielmfern
changed the title
react-dom/server.edge on edge environments
gabrielmfern
requested review from
a team and
lucasfcosta
and removed request for
rehanvdm and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant for partially fixing #1630 which is caused by a browser JS API trying to be used on the edge environment. React DOM does provide this
react-dom/server.edgeexport that you can use which doesn't use that API, and works for raw edge environments, like Cloudflare Workers. I've tested this on our Cloudflare Workers ExampleBut, when running in Next.js on the edge, this error happens after this pull request:
And according to vercel/next.js#71865, this happens because we're running React DOM in a React Server environment which isn't really allowed. Not sure what we can do to actually circumvent this, except for waiting for https://github.com/facebook/react/tree/main/packages/react-markup to get into a stable version, or use the experimental itself.